Skip to content

Commit

Permalink
Force --ci on server and monitor Docker build
Browse files Browse the repository at this point in the history
While `lerna bootstrap` was using --ci by default on Circle commands
in the config.yaml because CI=true on CircleCI,
it wasn't using this in server and monitor Docker builds.

This causes mismatching dependency versioning behavior.
Without --ci, the bootstrap command does not install exact versions but
install the latest version possible stated
e.g. ^1.2.3 could install 1.3.0
  • Loading branch information
kuzdogan committed Feb 24, 2023
1 parent 6d1ff15 commit 3bc5e88
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Dockerfile.monitor
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ WORKDIR /home/app
COPY packages ./packages
COPY src ./src
COPY *.json ./
RUN npx lerna bootstrap && npx lerna run build
RUN npx lerna bootstrap --ci && npx lerna run build

CMD ["npm", "run", "monitor:start"]
2 changes: 1 addition & 1 deletion src/Dockerfile.server
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ WORKDIR /home/app
COPY packages ./packages
COPY src ./src
COPY *.json ./
RUN npx lerna bootstrap && npx lerna run build
RUN npx lerna bootstrap --ci && npx lerna run build

CMD ["npm", "run", "server:start"]

0 comments on commit 3bc5e88

Please sign in to comment.