Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yul AST cleanup #7449

Closed
wants to merge 18 commits into from
Closed

Yul AST cleanup #7449

wants to merge 18 commits into from

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented Sep 18, 2019

Please Note

This PR is based on top of #7386. Please only have a look at the last three commits.

CheckList

  • remove FunctionInstruction
  • remove Instruction

@christianparpart
Copy link
Member Author

Moving out of draft, even though it's prerequisite PR isn't merged yet. (Please only have a look at the last 3 commits. :-) )

@christianparpart christianparpart force-pushed the yul-ast-cleanup branch 2 times, most recently from 663812a to 6efbe2a Compare September 25, 2019 09:11
@djudjuu
Copy link
Contributor

djudjuu commented Oct 28, 2019

Once these instructions have been removed, they will also need to be removed from the AsmJsonConverter (#7537) and from the AsmJsonImporter (#7153)

@Marenz
Copy link
Contributor

Marenz commented Nov 6, 2019

@christianparpart you can rebase this now, your base PR has been merged

@christianparpart
Copy link
Member Author

the replacement PRs have been created (and almost all merged).

@axic axic deleted the yul-ast-cleanup branch November 10, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants