Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rst syntax highlighting #4125

Closed
wants to merge 1 commit into from
Closed

Conversation

morenoh149
Copy link
Contributor

No description provided.

@morenoh149
Copy link
Contributor Author

morenoh149 commented May 12, 2018

CI seems to fail, enabling solidity syntaxhighlighting must require using Solidity or updating pygments. Skimming https://github.com/ethereum/solidity/search?utf8=%E2%9C%93&q=pygments&type=

@morenoh149 morenoh149 closed this May 12, 2018
@chriseth
Copy link
Contributor

Can you explain what you wanted to do here? We have our (well not very up to date) lexer set as default for all code here: https://github.com/ethereum/solidity/blob/develop/docs/utils/SolidityLexer.py

@chriseth
Copy link
Contributor

Oh now I see, somehow the highlighting has been switched off on readthedocs...

@chriseth
Copy link
Contributor

It seems to still work locally.

@chriseth
Copy link
Contributor

Seems to be a bug on readthedocs: readthedocs/readthedocs.org#4072

@chriseth
Copy link
Contributor

Hm, now it seems to be working again...

@morenoh149
Copy link
Contributor Author

morenoh149 commented May 14, 2018

my goal was to enable syntax highlighting on https://solidity.readthedocs.io/en/v0.4.23/solidity-by-example.html I'll have to clone the repo and see how to enable it. Sadly the fix wasn't as easy as doing what would work on github (which is what I tried).

@chriseth
Copy link
Contributor

I think this was an error on the readthedocs side. It is working for https://solidity.readthedocs.io/en/develop/ now. I wonder at which point the old versions stopped working and whether we can get them back somehow...

@morenoh149
Copy link
Contributor Author

ok, I'll subscribe to that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants