Yul: Object contains dialect #15534
Merged
Yul: Object contains dialect #15534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
yul_object_contains_dialect
branch
2 times, most recently
from
b19e741
to
a154d0a
Compare
matheusaaguiar
previously approved these changes
Oct 24, 2024
cameel
reviewed
Oct 24, 2024
cameel
requested changes
Oct 25, 2024
clonker
force-pushed
the
yul_object_contains_dialect
branch
from
a154d0a
to
a59ec52
Compare
matheusaaguiar
previously approved these changes
Oct 29, 2024
|
Is it contextualized enough now @cameel? |
|
Haven't managed to get back to this yet, but I think I'll have some time for that later today. |
cameel
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Yeah, it's better now. I can now see why the change is incomplete (the dialect is only needed for the new AST node types), but in that case taking it as far as possible still makes more sense. And removes more code from the original PR.
Overall this looks good, but there's one test helper where the dialect is not being set from the right source.
I also mentioned that the dialect belongs in the AST and should be passed with it all the way from parsing to printing. I think we should refactor it that way eventually, but it does not have to be now.
clonker
force-pushed
the
yul_object_contains_dialect
branch
from
a59ec52
to
371647c
Compare
cameel
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
yul::Objectto contain itsyul::Dialectin anticipation of the changes introduced in PR #15347.