eof: Add auxdataloadn to reserved identifiers. Move test to eof dir
#15529
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
rodiazet
force-pushed
the
eof-auxdataloadn-fix
branch
from
5b54415
to
5eeb51a
Compare
There was a problem hiding this comment.
It seems ok the way I see it here, but before we merge, please rebase on develop. We merged #15520 today, which affected EVMDialect implementation.
I see no conflicts, but I'd like to know if the shift introduced to handles by the EOF/non-EOF difference does not cause issues.
rodiazet
force-pushed
the
eof-auxdataloadn-fix
branch
from
5eeb51a
to
2859989
Compare
rodiazet
force-pushed
the
eof-auxdataloadn-fix
branch
from
2859989
to
5db362c
Compare
| if (_eofVersion.has_value()) | ||
| reserved += std::vector<std::string>{ | ||
| "auxdataloadn", | ||
| }; |
There was a problem hiding this comment.
@clonker I think we should refactor this so that reserved identifiers automatically contain all builtin names from the current dialect. Then remove the ones that are exceptions. What do you think? It would make this kind of mistake harder to make.
There was a problem hiding this comment.
Yes, absolutely. In my mind it is more likely that we add new reserved builtins compared to the amount of times we would be adding more exceptions.
No description provided.