-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Pass evmVersion
and eofVersion
to YulStack
in ObjectCompilerTest
#15503
test: Pass evmVersion
and eofVersion
to YulStack
in ObjectCompilerTest
#15503
Conversation
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it passes, it's good to go.
But would not hurt to also include the similarly hard-coded versions we saw in #15467 (comment).
6cef957
to
a5fd106
Compare
a5fd106
to
60e1482
Compare
60e1482
to
c38e4e6
Compare
EVMDialect::strictAssemblyForEVMObjects(solidity::test::CommonOptions::get().evmVersion(), | ||
solidity::test::CommonOptions::get().eofVersion()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EVMDialect::strictAssemblyForEVMObjects(solidity::test::CommonOptions::get().evmVersion(), | |
solidity::test::CommonOptions::get().eofVersion()), | |
EVMDialect::strictAssemblyForEVMObjects( | |
CommonOptions::get().evmVersion(), | |
CommonOptions::get().eofVersion() | |
), |
You don't need the solidity::test
bit in most places already and you can just add using namespace solidity::test
in those places that don't have it yet.
ObjectCompilerTest
inherits fromEVMVersionRestrictedTestCase
PUSH0
. These tests utilize this instruction.