Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pass evmVersion and eofVersion to YulStack in ObjectCompilerTest #15503

Merged

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Oct 10, 2024

  • Make ObjectCompilerTest inherits from EVMVersionRestrictedTestCase
  • Update object compiler test to EVM versions which enables PUSH0. These tests utilize this instruction.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@cameel cameel added the EOF label Oct 10, 2024
cameel
cameel previously approved these changes Oct 10, 2024
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes, it's good to go.

But would not hurt to also include the similarly hard-coded versions we saw in #15467 (comment).

@rodiazet rodiazet force-pushed the pass-cmdline-flags-to-object-compiler-test branch from 6cef957 to a5fd106 Compare October 11, 2024 09:00
@rodiazet rodiazet marked this pull request as ready for review October 11, 2024 09:02
@rodiazet rodiazet force-pushed the pass-cmdline-flags-to-object-compiler-test branch from a5fd106 to 60e1482 Compare October 11, 2024 12:57
@rodiazet rodiazet force-pushed the pass-cmdline-flags-to-object-compiler-test branch from 60e1482 to c38e4e6 Compare October 11, 2024 14:21
Comment on lines +66 to +67
EVMDialect::strictAssemblyForEVMObjects(solidity::test::CommonOptions::get().evmVersion(),
solidity::test::CommonOptions::get().eofVersion()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EVMDialect::strictAssemblyForEVMObjects(solidity::test::CommonOptions::get().evmVersion(),
solidity::test::CommonOptions::get().eofVersion()),
EVMDialect::strictAssemblyForEVMObjects(
CommonOptions::get().evmVersion(),
CommonOptions::get().eofVersion()
),

You don't need the solidity::test bit in most places already and you can just add using namespace solidity::test in those places that don't have it yet.

@cameel cameel merged commit 73b7dcd into ethereum:develop Oct 11, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants