Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eof: Support EOF asm analysis. #15471

Merged
merged 1 commit into from
Oct 9, 2024
Merged

eof: Support EOF asm analysis. #15471

merged 1 commit into from
Oct 9, 2024

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Oct 1, 2024 •
edited
Loading

  • Add AsmAnalysis support for EOF
  • Add compileTo flag to EVMVersionRestrictedTestCase

Depends on #15467 Merged.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@rodiazet rodiazet mentioned this pull request Oct 1, 2024
Merged
@cameel cameel added has dependencies The PR depends on other PRs that must be merged first EOF labels Oct 1, 2024
@cameel cameel removed the has dependencies The PR depends on other PRs that must be merged first label Oct 1, 2024
@rodiazet rodiazet force-pushed the eof-support-in-asm-analysis branch 5 times, most recently from 47f82ba to 1729a9c Compare October 2, 2024 13:17
@rodiazet rodiazet marked this pull request as ready for review October 2, 2024 13:17
cameel
cameel reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found some minor stuff: asserts, validations and maybe better names. Other than that it's perfectly fine and we can merge once those are addressed.

libyul/AsmAnalysis.cpp Outdated Show resolved Hide resolved
libyul/AsmAnalysis.cpp Show resolved Hide resolved
test/libyul/yulSyntaxTests/call_intruction_in_eof.yul Outdated Show resolved Hide resolved
test/libyul/yulSyntaxTests/call_intruction_in_eof.yul Outdated Show resolved Hide resolved
test/TestCase.cpp Outdated Show resolved Hide resolved
test/TestCase.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the eof-support-in-asm-analysis branch 9 times, most recently from 95c61e9 to 028e392 Compare October 8, 2024 20:51
cameel
cameel reviewed Oct 8, 2024
View reviewed changes
libyul/AsmAnalysis.cpp Outdated Show resolved Hide resolved
cameel
cameel reviewed Oct 8, 2024
View reviewed changes
test/TestCase.cpp Outdated Show resolved Hide resolved
cameel
cameel reviewed Oct 8, 2024
View reviewed changes
test/TestCase.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the eof-support-in-asm-analysis branch 3 times, most recently from 190d864 to 62ec9f2 Compare October 8, 2024 21:08
@rodiazet rodiazet force-pushed the eof-support-in-asm-analysis branch 2 times, most recently from b0c49c5 to 2aff7cf Compare October 8, 2024 21:17
cameel
cameel reviewed Oct 8, 2024
View reviewed changes
test/TestCase.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the eof-support-in-asm-analysis branch 2 times, most recently from c238db2 to a5357f6 Compare October 8, 2024 21:37
cameel
cameel previously approved these changes Oct 8, 2024
View reviewed changes
cameel
cameel previously approved these changes Oct 8, 2024
View reviewed changes
cameel
cameel reviewed Oct 8, 2024
View reviewed changes
test/TestCase.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the eof-support-in-asm-analysis branch 3 times, most recently from a0e3f44 to 88d6f91 Compare October 9, 2024 11:06
@cameel cameel merged commit d6fa849 into ethereum:develop Oct 9, 2024
73 checks passed
@cameel cameel mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

Assignees
No one assigned
Labels
EOF external contribution ⭐
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodiazet @cameel