Bump evmc and evmone images to v11 in CI #14758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a major release, so has to be done in the some PR #14743 |
cameel
force-pushed
the
bump-evmc-evmone-in-ci
branch
from
86af380
to
26f54d6
Compare
|
I'm moving the evmc update here from #14743. Also updating the hashes. |
cameel
reviewed
Jan 6, 2024
| - Note that you should delete (or not copy in the first place) `tooling.hpp` and `instructions.h`. | ||
| - Copy [`loader.c`](https://github.com/ethereum/evmc/blob/master/lib/loader/loader.c) to [test/evmc](https://github.com/ethereum/solidity/tree/develop/test/evmc) | ||
| - `MockedAccount.storage` in `mocked_host.hpp` should be changed to a `map` from `unordered_map` as ordering is important for fuzzing. You'll also need to include `<map>`. | ||
| See [PR #11094](https://github.com/ethereum/solidity/pull/11094) for more details. |
There was a problem hiding this comment.
I fixed the link. Originally it looked like this, which is not how links work in markdown (see c53afae):
[commit] for more details (https://github.com/ethereum/solidity/commit/788eb028255dc31aa108ac300dca52ad064fabf0)While at it I thought I'd replace it with the link to the PR, since that gives more context.
cameel
force-pushed
the
bump-evmc-evmone-in-ci
branch
from
26f54d6
to
4e7bb4e
Compare
cameel
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.