Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Analysis basic infrastructure #14538

Merged
merged 1 commit into from
Sep 13, 2023
Merged

New Analysis basic infrastructure #14538

merged 1 commit into from
Sep 13, 2023

Conversation

matheusaaguiar
Copy link
Collaborator

@matheusaaguiar matheusaaguiar commented Sep 6, 2023 •
edited
Loading

resolves #14531.
I cherry-picked the related files from commits in #14510 and made the necessary adjustments.

@matheusaaguiar matheusaaguiar force-pushed the experimentalAnalysisBasicInfrastructure branch 4 times, most recently from e8c8ec3 to 91025e0 Compare September 6, 2023 01:41
ekpyron
ekpyron reviewed Sep 6, 2023
View reviewed changes
liblangutil/Token.h Outdated Show resolved Hide resolved
@matheusaaguiar matheusaaguiar force-pushed the experimentalAnalysisBasicInfrastructure branch from 8b269ff to 5e54cf2 Compare September 6, 2023 20:19
cameel
cameel reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor tweaks I think we should do before merging this. I also added some readability tweaks as fixups.

But overall it looks fine. Honestly, I expected much more invasive changes in this PR :)

liblangutil/Token.h Outdated Show resolved Hide resolved
libsolidity/interface/CompilerStack.h Outdated Show resolved Hide resolved
liblangutil/Token.h Show resolved Hide resolved
@matheusaaguiar matheusaaguiar force-pushed the experimentalAnalysisBasicInfrastructure branch from b2b9204 to 14aed39 Compare September 11, 2023 15:30
@matheusaaguiar
Copy link
Collaborator Author

Rebased and squashed commits.

ekpyron
ekpyron approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ekpyron ekpyron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this after squashing it a bit (happened while I was approving ;-))!

@ekpyron ekpyron merged commit 9bce5f9 into develop Sep 13, 2023
1 check passed
@ekpyron ekpyron deleted the experimentalAnalysisBasicInfrastructure branch September 13, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel left review comments

@ekpyron ekpyron ekpyron approved these changes

Assignees
No one assigned
Labels
experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split out experimental analysis
3 participants
@matheusaaguiar @cameel @ekpyron