Properly distinguish team members and external contributors #13677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NunoFilipeSantos
previously approved these changes
Nov 3, 2022
|
Rebase for that green build please. |
r0qs
force-pushed
the
welcome-external-contributors
branch
from
d3c4341
to
c0c1ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
welcome-external-prworkflow to detect team members properly. The previous version did not handle pagination and consequently could produce false negatives, as can be seen here: #13675 (comment)The pagination was removed since it does not make sense for the size of the Solidity team, and a better endpoint was used, as suggested by @ekpyron.