[CI] Automate preparation of release binaries for publishing (via workspace) #12929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
circleci-release-binaries-via-workspace
branch
from
cb61e6b
to
35c69d0
Compare
cameel
commented
Apr 12, 2022
.circleci/config.yml
Outdated
Comment on lines
1439
to
1469
| name: Rename binaries to solc-bin naming convention | ||
| command: | | ||
| full_version=$( | ||
| github/solc-static-linux --version | | ||
| sed -En 's/^Version: ([0-9.]+.*\+commit\.[0-9a-f]+(\.mod)?).*$/\1/p' | ||
| ) | ||
|
|
||
| mkdir -p "solc-bin/{linux-amd64,macosx-amd64,windows-amd64,bin}" | ||
| mv github/solc-static-linux "solc-bin/linux-amd64/solc-linux-amd64-${full_version}" | ||
| mv github/macosx-amd64 "solc-bin/macosx-amd64/solc-macosx-amd64-${full_version}" | ||
| mv github/solc-windows.exe "solc-bin/windows-amd64/solc-windows-amd64-${full_version}.exe" | ||
| mv github/soljson.js "solc-bin/bin/soljson-${full_version}.js" |
There was a problem hiding this comment.
This is something I could also put in a script (see rename-circleci-binaries-for-solc-bin.sh in #12181), which would allow running it locally instead of renaming manually (this workflow will become obsolete after this PR though). It also fits better with the idea of not keeping bigger pieces bash code outside of CI config.
The way it's done here is much simpler though.
cameel
force-pushed
the
circleci-release-binaries-via-workspace
branch
2 times, most recently
from
eaec31a
to
1535fc6
Compare
|
Looks like it works. Removing the debug commit. For reference, here's a successful run: 1040499 |
cameel
force-pushed
the
circleci-release-binaries-via-workspace
branch
from
1535fc6
to
d7cb939
Compare
Marenz
reviewed
May 4, 2022
cameel
force-pushed
the
circleci-release-binaries-via-workspace
branch
from
d7cb939
to
15be7f3
Compare
Marenz
previously approved these changes
May 12, 2022
|
I switched to creating a tarball so that the executable flag is preserved. Here are the artifacts from a successful run: 1058937/artifacts. Now I'm removing the debug commit that enables this job outside of releases. |
cameel
force-pushed
the
circleci-release-binaries-via-workspace
branch
from
dda98dc
to
dbcffb7
Compare
ekpyron
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #12181.
Closes #9933.
This is a simplified version of #12181 (as discussed in #12181 (review)). Turns out it's possible to do it via workspace after all.
It's not complete automation of the publishing process as stated in #9933 but it at least takes care of the most tedious and error prone part of the process so I think it's good enough.
The PR adds a CI job that gathers release binaries from other jobs and attaches them as artifacts, under two naming conventions - for github release page and for solc-bin.