Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event overwritten with incompatible one #4803

Closed
frangio opened this issue Aug 12, 2018 · 3 comments
Closed

Event overwritten with incompatible one #4803

frangio opened this issue Aug 12, 2018 · 3 comments
Labels

Comments

@frangio
Copy link
Contributor

frangio commented Aug 12, 2018

The following code compiles without warnings, even though Foo overwrites the Approve(address,address) event with an incompatible one. This should fail to compile because it's not an overloading of Approve with a different signature, but a replacement of it with an incompatible one, because of the indexed.

pragma solidity ^0.4.24;

contract IFoo {
    event Approve(address a, address b);
}
contract Foo is IFoo {
    event Approve(address indexed a, address b);
}

Related to #4168.

@chriseth
Copy link
Contributor

@axic do we want to fix this with 0.5.0?

@leonardoalt leonardoalt self-assigned this Aug 29, 2018
@leonardoalt
Copy link
Member

@axic This is inheritance related, since the problem is that the events from the super contract are not propagating. Do we still want it for 0.5.0 or for the Inheritance project?

@chriseth
Copy link
Contributor

chriseth commented Apr 1, 2020

Duplicate of #3421

@chriseth chriseth marked this as a duplicate of #3421 Apr 1, 2020
@chriseth chriseth closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants