-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler does not consider events when validating contract inheritance #3421
Comments
Side note: I am blowing up with issues lately. Are my contributions welcome here, or am I complaining too much and wasting everyone's time? I'm doing this for fun, nobody is sponsoring me. So I hope this is having a positive impact. Is there a chat room for actual contributors here? Gitter is all beginner questions and is absolutely useless for me. What is the vetting process for me to become a member of the Ethereum github organization? |
@fulldecent yes, we noticed :) we have https://gitter.im/ethereum/solidity and https://gitter.im/ethereum/solidity-dev - the former is for users the latter for contributors. As far as the issue is concerned: This is actually not different for functions. We have an open issue to restrict such inheritance for functions, it would be great if you could cross-link that! |
Sorry I'm having trouble finding that other issue. But here is a test case:
|
Updated per call today |
This also compiles without warnings:
|
A longer discussion is #4168. |
Fixed in #9326 |
Decision from call:
error starting from 0.7.x
Test case 1:
And after #3419 ... test case 2
The text was updated successfully, but these errors were encountered: