Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "asm.js binaries in bin/ and wasm binaries in wasm/" #43

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Revert "asm.js binaries in bin/ and wasm binaries in wasm/" #43

merged 1 commit into from
Jul 17, 2020

Conversation

cameel
Copy link
Member

@cameel cameel commented Jul 17, 2020

Part of ethereum/solidity#9258.

This PR reverts #39, which inadvertently broke solc-js which is downloading stuff directly from the repo (rather than from GH pages) and due to that can't handle symlinks.

There's also this in other failing jobs (e.g. https://app.circleci.com/pipelines/github/ethereum/solidity/6672/workflows/79fb8b48-0558-4cf9-b3da-aeae56a83edc/jobs/392350):

Downloading version soljson-v0.6.11+commit.5ef660b1.js
 
Hash mismatch: 0xf0abd02c495a0b4c5c9a7ff20de8b932e11fc3066d0b754422035ecd96fcdbbc vs 0xac282607f7beba008c6fb82e5c453b21d9b9d8d28cddd465c150cc27cae4f1ca

I'm not reverting the changes to the update script since they make the script work for symlinks in other recently added directories.

@cameel cameel requested a review from chriseth July 17, 2020 11:06
@cameel cameel self-assigned this Jul 17, 2020
@chriseth chriseth merged commit 618e53a into gh-pages Jul 17, 2020
@cameel
Copy link
Member Author

cameel commented Jul 17, 2020 •
edited
Loading

I just tested it with solc-js locally and now it no longer fails.

$ node downloadCurrentVersion.js
Downloading correct solidity binary...
Retrieving available version list...
Downloading version soljson-v0.6.11+commit.5ef660b1.js
Done.

@cameel cameel deleted the revert-only-asmjs-binaries-in-bin branch July 17, 2020 15:07
This was referenced Jul 17, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

Assignees

@cameel cameel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameel @chriseth