This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
approved these changes
Nov 11, 2019
remix-tests/src/run.ts
Outdated
@@ -44,8 +44,10 @@ commander | |||
log.info('verbosity level set to ' + commander.verbose.blue) | |||
} | |||
let web3 = new Web3() | |||
let provider = new Provider() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are not reassigning the web3 and provider object you can use const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
remix-tests/src/run.ts
Outdated
@@ -44,8 +44,10 @@ commander | |||
log.info('verbosity level set to ' + commander.verbose.blue) | |||
} | |||
let web3 = new Web3() | |||
let provider = new Provider() | |||
await provider.init() | |||
web3.setProvider(provider) | |||
// web3.setProvider(new web3.providers.HttpProvider('http://localhost:8545')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments if you're not using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I see with this, eth_accounts is running twice @iurimatias |
I see even without these changes, eth_accounts runs twice. |
iurimatias
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the error in running test file using
remix-tests
through CLI