This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Makes plugin sendTransaction work with non-vm providers, adds tests #1301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though #1265 fixed silentRunTx to allow non-VM transactions, I found some issues while trying to use udapp.sendTransaction from a plugin:
undefined
and didn't know what the error was.result
object that the callback for silentRunTx() has 3 different forms depending on the environment and transaction type, but only the VM type was handled.This PR adds:
Please let me know if you want me to change anything. Thanks!