-
Notifications
You must be signed in to change notification settings - Fork 565
[Static analysis] Interaction with different addresses inside the loop handled #1242
Conversation
remix-analyzer/src/solidity-analyzer/modules/etherTransferInLoop.js
Outdated
Show resolved
Hide resolved
I am tracking ether transfer in for, while and do-while loop. |
tests have been added |
sounds like this can be merged, |
@yann300 can you please comment on the code to refer it? |
Without AST, I don't think it is possible. For better view, I can put the loop ASTs in different file or we can do it for all AST blocks in the tests file in another go. What you suggest @yann300 |
Perhaps to compile the code and get the ast... yeah but we might not want having another dependency only for testing. ok putting it in a different file would be fine. |
I am thinking to do that in next PR along with putting all the AST blocks in separate file for future use too. |
ok sure |
fixes #854
This can be further improved with discussion.