Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

[Static analysis] Interaction with different addresses inside the loop handled #1242

Merged
merged 3 commits into from
Sep 27, 2019

Conversation

Aniket-Engg
Copy link
Collaborator

fixes #854

This can be further improved with discussion.

@Aniket-Engg
Copy link
Collaborator Author

I am tracking ether transfer in for, while and do-while loop.

@Aniket-Engg
Copy link
Collaborator Author

tests have been added

@yann300
Copy link
Collaborator

yann300 commented Sep 20, 2019

sounds like this can be merged,
would it just be possible to run tests without copy/pasting the entire block of ASTs ?

@Aniket-Engg
Copy link
Collaborator Author

@yann300 can you please comment on the code to refer it?

@yann300
Copy link
Collaborator

yann300 commented Sep 20, 2019

@Aniket-Engg
Copy link
Collaborator Author

Aniket-Engg commented Sep 27, 2019

sounds like this can be merged,
would it just be possible to run tests without copy/pasting the entire block of ASTs ?

Without AST, I don't think it is possible. For better view, I can put the loop ASTs in different file or we can do it for all AST blocks in the tests file in another go. What you suggest @yann300

@yann300
Copy link
Collaborator

yann300 commented Sep 27, 2019

Perhaps to compile the code and get the ast... yeah but we might not want having another dependency only for testing. ok putting it in a different file would be fine.

@Aniket-Engg
Copy link
Collaborator Author

Perhaps to compile the code and get the ast... yeah but we might not want having another dependency only for testing. ok putting it in a different file would be fine.

I am thinking to do that in next PR along with putting all the AST blocks in separate file for future use too.

@yann300
Copy link
Collaborator

yann300 commented Sep 27, 2019

ok sure

@Aniket-Engg Aniket-Engg merged commit b93b357 into ethereum:master Sep 27, 2019
@Aniket-Engg Aniket-Engg deleted the fix/#854 branch September 27, 2019 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Static analysis] Interaction with different addresses inside the loop
2 participants