This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Set language for solidity compiler #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
approved these changes
Jun 17, 2019
| @@ -94,7 +100,7 @@ function Compiler (handleImportCall) { | |||
|
|
|||
| var result | |||
| try { | |||
| var input = compilerInput(source.sources, {optimize: optimize, evmVersion: evmVersion, target: source.target}) | |||
| var input = compilerInput(source.sources, {optimize: optimize, evmVersion: evmVersion, language: language, target: source.target}) | |||
There was a problem hiding this comment.
For making it easier to read you could do : { optimize, evmVersion, language, taget: source.target }
| @@ -301,7 +307,7 @@ function Compiler (handleImportCall) { | |||
| compileJSON = function (source) { | |||
| jobs.push({sources: source}) | |||
| worker.postMessage({cmd: 'compile', job: jobs.length - 1, input: compilerInput(source.sources, | |||
| {optimize: optimize, evmVersion: evmVersion, target: source.target})}) | |||
| {optimize: optimize, evmVersion: evmVersion, language: language, target: source.target})}) | |||
| @@ -29,6 +29,8 @@ function Compiler (handleImportCall) { | |||
|
|
|||
| var evmVersion = null | |||
|
|
|||
| var language = 'Solidity' | |||
There was a problem hiding this comment.
You can use let here.
There was a problem hiding this comment.
yes you're right but i'd prefer to let this TODO for the typescript rewrite (all the other var are var...)
This was referenced Dec 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it can be switched to
Yul