-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-8 #32
EIP-8 #32
Conversation
@ms83 I can't get full app tests to pass (see Travis output in this PR). Do they pass for you? |
5a4d415
to
40cbde2
Compare
Alright. We've decided to go forward with EIP-8, so this PR is now open for review. I still can't get the full app tests to pass. I tried cherry picking the first few commits from #35 but it didn't help. |
This is required because RLPxSession matches on RuntimeError to catch decryption failures.
Rebased again. Tests work now (thanks @ulope). You can test the RLPx handshake changes against go-ethereum by doing:
|
@fjl awesome! thank you! |
oops...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working
Implements ethereum/EIPs#49.