Expose and test petersburg_at and latest_mainnet_at #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, note that petersburg is the canonical mainnet VM, not constantinople.
pipermerriam
approved these changes
Jun 4, 2019
| @@ -234,6 +237,8 @@ def dao_fork_at(dao_fork_block_number: BlockNumber, | |||
| petersburg_at = fork_at(PetersburgVM) | |||
| istanbul_at = fork_at(IstanbulVM) | |||
|
|
|||
| latest_mainnet_at = petersburg_at | |||
There was a problem hiding this comment.
👍 to not making this magic so tests don't suddenly start failing without this being updated explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
petersburg_atwasn't exposed ineth.tools.builder.chain.No easy way to use the chain builder to always test the latest VM. (Every network upgrade would require updating the tests explicitly)
How was it fixed?
Exposed
petersburg_at()andlatest_mainnet_at().Cute Animal Picture