This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adding a develop menu option to open Remix IDE #1608
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0d79743
Adding browser solidity menu item
evertonfraga 0dc787b
Adding i18n keys for Remix menu item
evertonfraga d3eeebb
Merge branch 'develop' into ev_add_browsersol
evertonfraga 02c3bad
Moving Remix menu option UP
evertonfraga 0af1271
Opening Remix on a separated popup
evertonfraga aa5e9db
Changing display name
evertonfraga dab23f0
Merge branch 'ev_add_browsersol' of https://github.com/ethereum/mist …
evertonfraga 04c9c2f
minor refactor
evertonfraga b84f158
reverting travis change
evertonfraga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -131,6 +131,17 @@ ipcRenderer.on('uiAction_runTests', (e, type) => { | |
} | ||
}); | ||
|
||
// Open Browser Solidity | ||
ipcRenderer.on('uiAction_openBrowserSolidity', () => { | ||
Tabs.upsert('browserSol', { | ||
position: Tabs.find().count(), | ||
name: 'Remix', | ||
redirect: 'https://ethereum.github.io/browser-solidity/', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use |
||
}); | ||
|
||
Tracker.afterFlush(() => LocalStore.set('selectedTab', 'browserSol')); | ||
}); | ||
|
||
|
||
// CONTEXT MENU | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to use
remix
throughout instead ofbrowsersol
orBrowserSolidity
(below).