Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

New confirmation pane #1141

Merged
merged 24 commits into from
Sep 14, 2016
Merged

New confirmation pane #1141

merged 24 commits into from
Sep 14, 2016

Conversation

alexvandesande
Copy link

No description provided.

@alexvandesande
Copy link
Author

Ready to be merged

@@ -0,0 +1,9 @@
root = true
Copy link
Contributor

@luclu luclu Sep 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editor config can be excluded locally only by using .git/info/exclude instead of .gitignore (same syntax).

@luclu
Copy link
Contributor

luclu commented Sep 8, 2016

@alexvandesande here is some cropped text-field I ran into:

edit: well, my OSX's scrolling did break, had to reboot. ;)
Perhaps the fade area could be enlarged and also set apart a bit further from the password input-field to make the visual distinction and scroll-ability more obvious.

bildschirmfoto 2016-09-08 um 22 44 10

@luclu
Copy link
Contributor

luclu commented Sep 9, 2016

There seems to be some issue with the SSL access (to 4bytes?) when trying to decode the data (on main-net and test-net):

bildschirmfoto 2016-09-08 um 23 34 59

Also, at some point in time using this branch I could not input any text in any text-field anymore (only deleting) until I restarted Ethereum-Wallet. I will try to observe and reproduce this.

@alexvandesande alexvandesande merged commit 581cd8e into develop Sep 14, 2016
@evertonfraga evertonfraga deleted the new-confirmation-pane branch September 14, 2016 20:58
@evertonfraga evertonfraga added this to the 0.8.3 milestone Sep 14, 2016
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants