all: remove TerminalTotalDifficultyPassed #30609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stevemilk <[email protected]>
jwasinger
requested review from
fjl,
holiman,
karalabe,
gballet,
rjl493456442,
zsfelfoldi,
s1na and
lightclient
as code owners
… into its own commit as a reminder to double-check that this doesn't break anything
|
hi, I didn't notice you create one too. I just re-commit the PR #30612, including more deletion of TerminalTotalDifficultyPassed. |
|
your commit contains my updates, closing mine. |
…cified. Remove unused parts from HF description generation
…x possible). Otherwise, we cannot create the consensus engine if ttd==nil.
…ensus engine creation ensures this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #29766 . The downstream branch appears to have been deleted and I don't have perms to push to that fork.