-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Gnark Bn254 precompile methods for fuzzing #30585
base: master
Are you sure you want to change the base?
Conversation
running
|
running BenchmarkPrecompiledBn256Add after change with Option 3:
|
running BenchmarkPrecompiledBn256Add after change with Option 2:
|
running BenchmarkPrecompiledBn256Add after change with Option 1:
|
running BenchmarkPrecompiledBn256ScalarMul before this change:
after this change:
|
running BenchmarkPrecompiledBn256Pairing before this change:
after this change:
Note: |
Could you also add it to the fuzzer already? |
Yep, I'll modify the fuzzer code
Alright, I'll delete the g1_aff code and go with
I'll open up an issue in Gnark to upstream this -- its not in gnark because its catering to a specific usecase that is expensive for every other usecase. |
This adds the gnark precompile methods so that they can be used as fuzzing and perhaps in the future replace the google variant; I noticed that the google variant looked quite similar to the cloudflare one.