eth/catalyst,beacon/engine: implement GetClientVersionV1 #28915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Feb 5, 2024
|
Spec has been changed to return an array of versions. |
|
Okay the PR was merged ethereum/execution-apis#517, this should be good to go! |
fjl
reviewed
Feb 13, 2024
| Code: engine.ClientCode, | ||
| Name: engine.ClientName, | ||
| Version: params.VersionWithMeta, | ||
| Commit: hexutil.Encode(commit), |
There was a problem hiding this comment.
This will add 0x in the commit. Is this seriously what they decided on within the spec?
There was a problem hiding this comment.
It's type DATA which should have the 0x prefix https://github.com/ethereum/execution-apis/blob/main/src/engine/common.md#encoding
fjl
approved these changes
Feb 13, 2024
|
Looks like you forgot to add it into the list of capabilites |
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new method
engine_getClientVersionV1. Still waiting it to be merged here: ethereum/execution-apis#517