Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: fix flaky test #28864

Merged
merged 1 commit into from
Jan 24, 2024
Merged

ethclient: fix flaky test #28864

merged 1 commit into from
Jan 24, 2024

Conversation

rjl493456442
Copy link
Member

Fix flaky test due to incomplete transaction indexing

    --- FAIL: TestEthClient/StatusFunctions (0.00s)
        ethclient_test.go:481: unexpected progress: &{0 2 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0}

holiman
holiman approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.13.11 milestone Jan 24, 2024
@holiman holiman merged commit 765f290 into ethereum:master Jan 24, 2024
2 of 3 checks passed
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@rjl493456442 @Dergarcon
ethclient: fix flaky test (ethereum#28864)
eb70937 
Fix flaky test due to incomplete transaction indexing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.11
Development

Successfully merging this pull request may close these issues.
2 participants
@rjl493456442 @holiman