core/state/snapshot: use AddHash/ContainHash instead of Hasher interface #28849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the allocations quite significantly, before:
26666581 26666581 243: dl.diffed.Add(storageBloomHasher{accountHash, storageHash})
MariusVanDerWijden
requested review from
karalabe,
holiman and
rjl493456442
as code owners
rjl493456442
approved these changes
Jan 22, 2024
holiman
approved these changes
Jan 22, 2024
core/state/pruner/bloom.go
Outdated
| func (f stateBloomHasher) BlockSize() int { panic("not implemented") } | ||
| func (f stateBloomHasher) Size() int { return 8 } | ||
| func (f stateBloomHasher) Sum64() uint64 { return binary.BigEndian.Uint64(f) } | ||
| // stateBloomHasher is used to convert a trie hash or contract code hash into a 64 bit mini hash. |
There was a problem hiding this comment.
Now that these no longer are types (objects), but rather functions (verbs), perhaps they should be renamed from stateBloomHasher into stateBloomHash ?
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
…ace (ethereum#28849) This change switches from using the `Hasher` interface to add/query the bloomfilter to implementing it as methods. This significantly reduces the allocations for Search and Rebloom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from using the Hasher interface to add/query the bloomfilter to implementing it as methods.
This significantly reduces the allocations for Search and Rebloom.
The allocations for the storageBloom alone was ~7% of all allocations (in a quite contrived scenario)
26666581 26666581 243: dl.diffed.Add(storageBloomHasher{accountHash, storageHash})14812039 14812039 375: hit := dl.diffed.Contains(storageBloomHasher{accountHash, storageHash})14828423 14849723 (flat, cum) 2.50% of Total26666581 26672121 (flat, cum) 4.49% of TotalThe added benefit of reduced allocations also surfaces in the benchmark: