internal/ethapi: avoid using pending for defaults #28784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
Given the discussions around deprecating pending (see ethereum#28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these two instances where we are estimating gas and computing the access list for a tx on top of the pending block. Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from it internally.