core/vm: performance tweak of OpCode.String()
#28453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmittmann
requested review from
karalabe,
holiman and
rjl493456442
as code owners
holiman
changed the title
OpCode.String()OpCode.String()
rjl493456442
approved these changes
Nov 2, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
make `opCodeToString` a `[256]string` array Co-authored-by: lmittmann <[email protected]>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 0622724.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 0622724.
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
make `opCodeToString` a `[256]string` array Co-authored-by: lmittmann <[email protected]>
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
make `opCodeToString` a `[256]string` array Co-authored-by: lmittmann <[email protected]>
colinlyguo
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 31, 2024
make `opCodeToString` a `[256]string` array Co-authored-by: lmittmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change that improves the performance of
OpCode.String()by changing:Yes, but we can use an array and define opcodes using a key-value-pair as one would do in a map (so order still does not matter).