crypto/blake2b: only fuzz non-generic functions if enabled #28381
+75
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works on my local oss-fuzz build |
holiman
reviewed
Oct 19, 2023
Comment on lines
+2
to
+3
| //go:build go1.7 && amd64 && !gccgo && !appengine | ||
| // +build go1.7,amd64,!gccgo,!appengine |
There was a problem hiding this comment.
//go:build go1.7 && amd64 && gc && !purego
appengine is obsolete and superseded by purego, and gc is a more
precise tag for files that use gc-syntax assembly.
Source https://cs.opensource.google/go/x/crypto/+/be400aefbc4c83e9aab51e82b8d4b12760653b47 via https://cs.opensource.google/go/x/crypto/+/master:blake2b/;bpv=1
But IMO it's fine to leave it as is, so it uses the exact same logic as the other files in this package
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#28381) This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ild-tag (ethereum#28381)" This reverts commit 5e9d8bd.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ild-tag (ethereum#28381)" This reverts commit 5e9d8bd.
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
…thereum#28381) This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to unbork master by only enabling the fuzzer if non-generic functions can be accessed (which is not the case on 32-bit platforms)