cmd, core: resolve scheme from a read-write database #28313
Conversation
| @@ -64,7 +63,6 @@ var Defaults = Config{ | |||
| TxLookupLimit: 2350000, | |||
| TransactionHistory: 2350000, | |||
| StateHistory: params.FullImmutabilityThreshold, | |||
| StateScheme: rawdb.HashScheme, | |||
There was a problem hiding this comment.
Note, it's necessary to remove the default value, otherwise hash mode is always picked if user doesn't specify via cli flag.
There was a problem hiding this comment.
Well, we could leave it, if we do something like this
func ParseStateScheme(provided, default string, disk ethdb.Database) (string, error) {
and call it via
provided = ""
if ctx.IsSet(StateSchemeFlag.Name){
provided = ctx.String(StateSchemeFlag.Name)
}
scheme, err := rawdb.ParseStateScheme(provided, ctx.String(StateSchemeFlag.Name), disk)I don't know if it's worth it though
There was a problem hiding this comment.
FWIW, perhaps it's better to not have HashScheme set in configs unless teh user explicitly does so. Otherwise someone who doesn't care and just did a dumpconfig will forever be stuck on Hash since it will keep forcing it. Otherwise if they don't care and dumpconfig omits it, they would switch to path when the default flips too.
There was a problem hiding this comment.
I mean when they resync. I can imagine people keeping configs around longer than their chain.
* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts
* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts
* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts
* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts
This pull request provides a quick solution for fixing issue #28307
This issue can occur when unclean shutdown happens and freezer tables need to be repair. In database read-only mode, the freezer will only be validated but not repair and terminates the node abnormally.
This pull request moves the scheme check into the Ethereum constructor where the read-write database is already initialized. This approach can avoid opening read-only database in very early stage, to prevent this error totally.