p2p: move ping handling into pingLoop goroutine #27887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
rjl493456442
approved these changes
Aug 9, 2023
battlmonstr
added a commit
to erigontech/erigon
that referenced
this pull request
Sep 1, 2023
DarianShawn
pushed a commit
to dogechain-lab/dbsc
that referenced
this pull request
Sep 3, 2023
### Description upstream PR: [go-ethereum#27887](ethereum/go-ethereum#27887) Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
yperbasis
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
yperbasis
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
Thegaram
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Sep 12, 2023
* p2p: move ping handling into pingLoop goroutine (ethereum#27887) Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup. * bump version --------- Co-authored-by: Felix Lange <[email protected]>
15 tasks
wgr523
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Oct 27, 2023
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
wgr523
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Oct 31, 2023
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
This was referenced Oct 31, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 951c49d.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 951c49d.
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Jan 29, 2024
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
otherview
pushed a commit
to vechain/go-ethereum
that referenced
this pull request
Mar 8, 2024
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
libotony
pushed a commit
to vechain/go-ethereum
that referenced
this pull request
Mar 8, 2024
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
jyap808
pushed a commit
to ubiq/go-ubiq
that referenced
this pull request
Mar 21, 2024
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup. (cherry picked from commit 7ec60d5)
InnerPeace080
pushed a commit
to titantkx/go-ethereum
that referenced
this pull request
Apr 29, 2024
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
cp-wjhan
pushed a commit
to cp-wjhan/go-metadium
that referenced
this pull request
May 28, 2024
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the response sending there allows tracking all peer goroutines in the peer WaitGroup.