Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql: validate block params #27876

Merged
merged 2 commits into from
Aug 10, 2023
Merged

graphql: validate block params #27876

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c8eb3e
graphql: reject both block num and hash args
s1na Aug 7, 2023
97f537f
Update graphql/graphql.go
s1na Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions graphql/graphql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,6 +1207,9 @@ func (r *Resolver) Block(ctx context.Context, args struct {
Number *Long
Hash *common.Hash
}) (*Block, error) {
if args.Number != nil && args.Hash != nil {
return nil, errors.New("either number or hash must be specified")
s1na marked this conversation as resolved.
Show resolved Hide resolved
}
var numberOrHash rpc.BlockNumberOrHash
if args.Number != nil {
if *args.Number < 0 {
Expand Down