Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: ethSendTransaction check baseFee #27834

Merged
merged 16 commits into from
Dec 18, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 1, 2023

This is a similar issue to #27833, but this is for the eth_sendTransaction RPC.

When I send the transaction with

  • gasPrice=1 => failed ❌
  • gasPrice=0 => success πŸ†—
image

After some dig, and talking with @rjl493456442 found the issue occurred by estimateGas,

the stack trace as below:

image

So when I call estimateGas, I distinguish between a call from eth_call or submitted transaction

@jsvisa jsvisa requested a review from s1na as a code owner August 1, 2023 16:00
internal/ethapi/api.go Outdated Show resolved Hide resolved
@rjl493456442
Copy link
Member

rjl493456442 commented Aug 2, 2023

I think the main issue is that we allow zero price transactions from RPC, these transactions
are invalid if 1559 is activated. We can add the check in an alternative approach:

  • if the 1559 is activated
  • reject the 0 price tx in the rpc level

This check can be done https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/transaction_args.go#L135

@holiman
Copy link
Contributor

holiman commented Aug 2, 2023

Some historic background: #23027

@jsvisa
Copy link
Contributor Author

jsvisa commented Aug 3, 2023

@rjl493456442 @holiman please take another look, I changed to check the gasPrice zeroable after London only.

@jsvisa jsvisa requested a review from holiman August 15, 2023 17:45
@holiman holiman modified the milestone: 1.13.6 Dec 18, 2023
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants