-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ethapi: ethSendTransaction check baseFee #27834
Conversation
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
I think the main issue is that we allow zero price transactions from RPC, these transactions
This check can be done https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/transaction_args.go#L135 |
Some historic background: #23027 |
This reverts commit aa47d01. Signed-off-by: jsvisa <[email protected]>
This reverts commit 21dffcb. Signed-off-by: jsvisa <[email protected]>
This reverts commit f067656. Signed-off-by: jsvisa <[email protected]>
β¦heck" This reverts commit eeaaeb2. Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
@rjl493456442 @holiman please take another look, I changed to check the gasPrice zeroable after London only. |
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
This is a similar issue to #27833, but this is for the
eth_sendTransaction
RPC.When I send the transaction with
gasPrice=1
=> failed βgasPrice=0
=> success πAfter some dig, and talking with @rjl493456442 found the issue occurred by
estimateGas
,the stack trace as below:
So when I call
estimateGas
, I distinguish between a call frometh_call
or submitted transaction