Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/abi/bind/backends: fix goroutine leak in unit test #27705

Merged
merged 4 commits into from
Jul 15, 2023
Merged

accounts/abi/bind/backends: fix goroutine leak in unit test #27705

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7779c75
stop the blockchain service with defer
yuriechan Jul 12, 2023
6af4c37
trigger ci
yuriechan Jul 12, 2023
f4d2162
remove goleak usage and its dependency
yuriechan Jul 13, 2023
6a45bd2
trigger ci
yuriechan Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions accounts/abi/bind/backends/simulated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ func TestAdjustTime(t *testing.T) {
func TestNewAdjustTimeFail(t *testing.T) {
testAddr := crypto.PubkeyToAddress(testKey.PublicKey)
sim := simTestBackend(testAddr)
defer sim.blockchain.Stop()

// Create tx and send
head, _ := sim.HeaderByNumber(context.Background(), nil) // Should be child's, good enough
Expand Down