internal/ethapi: use RPCBlock,RPCHeader instead of interface

[jsvisa]

This is a follow-up PR by #27265, If it's OK I'll add more test cases for getXXX's response to ensure no alter the spec of RPC's response.

[lightclient]

Suggested change

	TotalDifficulty *hexutil.Big `json:"totalDifficulty"`
	TotalDifficulty *hexutil.Big `json:"totalDifficulty,omitEmpty"`

Why not omit empty and get rid of the null values?

[jsvisa]

because the totalDifficulty of get{Header,Block}ByNumber's response is null

[holiman]

Why changing the raw string comparison into a json-equality check?

[jsvisa]

seems the JSON serialization order is differ

[holiman]

We've discussed this PR in triage, and decided not to include it: the addition of these new types does not seem to bring sufficient advantages.
These types are also in an internal package, and thus does not help external users either.
Thanks for the effort you put in!

[jsvisa]

@holiman anyway, thanks for your reply.

These types are also in an internal package, and thus does not help external users either.

I want to declare them first in the internal package, if this PR was merged, I'm considering moving them out into some package like rpc/jsonrpc or other names. do you think this is feasible?

[lightclient]

rpc is a generic rpc package so I don't think it would be good to move the eth-specific definitions into that package. What use would exporting these values serve though? We generally use ethclient as the go interface for rpc values?

[jsvisa]

Here is a transaction example, in ethclient we did can retrieve the transaction body via TransactionByHash, but the response is tx *types.Transaction, which missing some import fields(blockNumber, blockHash, From) while the raw eth_getTransactionByHash RPC can retrieve those fields.

For this case seems we can make this struct into a public one:

go-ethereum/ethclient/ethclient.go

Line 208 in aa47d01

type rpcTransaction struct {

,

or this txJSON into a public one:

go-ethereum/core/types/transaction_marshalling.go

Line 30 in aa47d01

type txJSON struct {

BTW, does anyone know why we return this function as tx, isPending, error without blockNumber, blockHash, From fields?