metrics: use sync.map in registry #27159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Apr 25, 2023
holiman
reviewed
Apr 25, 2023
holiman
reviewed
May 2, 2023
holiman
approved these changes
May 8, 2023
There was a problem hiding this comment.
LGTM. I agree about using sync.Map here, the speed-improvements on multithreaded Get-operations are pretty awesome.
Parallel get is performed e.g. in the p2p/tracker/tracker.go, aswell as lazy message handlers for both eth and snap protocol (if enabled.expensive), the p2p/transport.go etc
|
Todo: I'll try it on a benchmarker |
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit dd2f5b3.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit dd2f5b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the registry from mutex protected map to sync.map implementation.
The registry is mostly read-heavy due to GetOrRegister method being used for tracking packets and rpc. Besides that most of the primitives are created at initialization and never unregistered. It sounds like a good place for sync.map.
Some stats: