console: fix windows console colors #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Wed Jun 8 10:51:39 UTC 2016 |
Current coverage is 56.97%@@ develop #2669 diff @@
==========================================
Files 216 216
Lines 24642 24642
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 14035 14041 +6
+ Misses 10605 10601 -4
+ Partials 2 0 -2
|
karalabe
force-pushed
the
fix-windows-console-color
branch
from
f364dbc to
d251d48
Compare
|
👍 |
|
👍 |
Merged
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 24, 2024
Draft release v1.4.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github.com/fatih/color we use to colorize the console output added Windows support in a weird way, colorizing for Linux and then converting the colors on the fly to Windows before writing it to stdout. However since the console PR rewrote stdin/stdout handling, the color package never got around to actually transform it's Linux colors to Windows, breaking for Windows users. This PR essentially does this missing step of wrapping the output stream with a linux->windows color converter manually by the console.
Fixes #2668.