Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, cmd: fill blockNumber in logs #26345

Merged
merged 4 commits into from
Dec 13, 2022
Merged

core, cmd: fill blockNumber in logs #26345

merged 4 commits into from
Dec 13, 2022

Conversation

rjl493456442
Copy link
Member

No description provided.

holiman
holiman approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minor nit)

core/state/statedb.go Show resolved Hide resolved
s1na
s1na approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjl493456442 @holiman
Update core/state/statedb.go
9eb1b7e 
Co-authored-by: Martin Holst Swende <[email protected]>
fjl
fjl reviewed Dec 12, 2022
View reviewed changes
core/types/log.go Outdated Show resolved Hide resolved
@holiman holiman added this to the 1.11.0 milestone Dec 13, 2022
@holiman
Copy link
Contributor

holiman commented Dec 13, 2022

Sorry, something about my comment is not approved by the linter, for some reason

core/state/statedb.go:209: File is not `goimports`-ed (goimports)
// GetLogs returns the logs matching the specified transaction hash, and annotates them with the given blocknumber/blockhash

@holiman holiman merged commit cda051e into ethereum:master Dec 13, 2022
@Tristan-Wilson Tristan-Wilson mentioned this pull request Feb 28, 2023
Merged
13 tasks
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
@rjl493456442 @holiman @shekhirin
core, cmd: fill blockNumber in logs (ethereum#26345)
94a2a60 
* core, cmd: fill blockNumber in logs

* Update core/state/statedb.go

Co-authored-by: Martin Holst Swende <[email protected]>

* core/types: revert

* core/state: improve comments

Co-authored-by: Martin Holst Swende <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl left review comments

@s1na s1na s1na approved these changes

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rjl493456442 @holiman @fjl @s1na