eth/filters, eth/tracers: add request cancellation checks #26320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested review from
s1na,
karalabe,
holiman and
rjl493456442
as code owners
This ensures that RPC method handlers will react to a timeout or cancelled request soon after the event occurs.
fjl
force-pushed
the
eth-tracer-cancel-check
branch
from
5649ee3
to
eacf53d
Compare
fjl
commented
Dec 7, 2022
eth/tracers/api.go
Outdated
| case jobs <- task: | ||
| case <-ctx.Done(): | ||
| failed = ctx.Err() | ||
| break |
There was a problem hiding this comment.
Classic mistake here, break here will terminate the select instead of enclosing loop.
s1na
reviewed
Dec 7, 2022
| for i, tx := range txs { | ||
| // Send the trace task over for execution | ||
| jobs <- &txTraceTask{statedb: statedb.Copy(), index: i} | ||
| task := &txTraceTask{statedb: statedb.Copy(), index: i} | ||
| select { |
There was a problem hiding this comment.
Is this more efficient than simply checking ctx.Err() at the beginning of the loop?
There was a problem hiding this comment.
It's not more efficient, I just did it because the send could theoretically block at this point. Canceling the context would unblock it. However, it seems the jobs channel is actually buffered, and so the send will always succeed.
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
…6320) This ensures that RPC method handlers will react to a timeout or cancelled request soon after the event occurs. Co-authored-by: Sina Mahmoodi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that RPC method handlers will react to a timeout or cancelled request soon after the event occurs.