Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add sync mode requirements for issue #20260 #24931

Closed
wants to merge 2 commits into from

Conversation

lhendre
Copy link
Contributor

@lhendre lhendre commented May 23, 2022

Adding in missing syncmode documentation as requested in issue #20260

Added in full, fast and snap with flag examples. Based on information provided in the Ethereum blog here https://blog.ethereum.org/2021/03/03/geth-v1-10-0/

@s1na
Copy link
Contributor

s1na commented May 23, 2022

The ticket you referenced is about missing pages on the website. If you'd like to contribute to a page about sync modes please see the branch gh-pages where our website is hosted.

Also note that fast sync mode is deprecated and not shipped with the most recent geth release.

My 2cents is that the README is already overloaded and we don't really need to add this there. But will wait for other people to chime in.

@lhendre
Copy link
Contributor Author

lhendre commented May 24, 2022

I read it as the README/the readme was acceptable given #24395, that being said can move or drop the pr so will wait for others to chime in or move it based on your feedback if they dont.

Ill leave fast sync but add in that information if that works

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to mix in things like how long it takes, which differs a lot across hardware and networks and locations.
I also don't agree with the descriptions of the trust model(s), for fast-sync (which is the same as snap sync).

@ligi
Copy link
Member

ligi commented May 24, 2022

The content is also on the website - let's not dup it: ethereum/ethereum-org-website#3885

@ligi ligi closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants