signer, accounts: move eip-712 types to apitypes package. fixes #23972 #24029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about moving the content-type constants. The move adds multiple dependencies on signer/core/apitypes that weren't there before. I think we could leave these constants in package accounts for now. |
fjl
approved these changes
Dec 5, 2021
ivanshukhov
pushed a commit
to Kapoio/go-kapoio
that referenced
this pull request
Dec 11, 2021
Fixes ethereum#23972 (cherry picked from commit 619a3e7)
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves things around a bit, should fix #23972.
Other than moving things around (and a little bit of docs added), nothing should have changed.