core/vm: Rename opSuicide to opSelfdestruct #24022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
requested review from
holiman,
karalabe and
rjl493456442
as code owners
axic
changed the title
The opcode was renamed in the codebase in 2017, but the functions were kept unchanged.
axic
force-pushed
the
evm-selfdestruct
branch
from
752788c to
4fb7927
Compare
holiman
approved these changes
Dec 1, 2021
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
The opcode was renamed in the codebase in 2017, but the functions were kept unchanged.
This was referenced Sep 23, 2022
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
The opcode was renamed in the codebase in 2017, but the functions were kept unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opcode was renamed in the codebase in 2017, but the functions were kept unchanged.
There are many other places where
suicideis used as a term, including a lot incore/state(such asStateDB.Suicide) and theSuicide/HasSuicidedinterface incore/vm. The nitpicker in me would try to rename all those, but that may be too much for little benefit.Let me know if this change here is not very useful and I'll avoid doing anything similar later.