cmd/geth: add db cmd to show metadata #23900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/geth/dbcmd.go
Outdated
| data = append(data, [][]string{{"frozen", fmt.Sprintf("%v", ancients)}, | ||
| {"lastPivotNumber", pp(rawdb.ReadLastPivotNumber(db))}, | ||
| {"snapshotSyncStatus", fmt.Sprintf("%d bytes", len(rawdb.ReadSnapshotSyncStatus(db)))}, | ||
| {"snapshotGenerator", fmt.Sprintf("%x", rawdb.ReadSnapshotGenerator(db))}, |
There was a problem hiding this comment.
It doesn't make sense to show the byte format generator. Maybe we can decode the content and show the real info? We can define a public function to decode the generator in the snapshot package I think.
|
@rjl493456442 something like this? |
cmd/geth/dbcmd.go
Outdated
| @@ -20,6 +20,7 @@ import ( | |||
| "bytes" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/ethereum/go-ethereum/core/state/snapshot" | |||
core/state/snapshot/journal.go
Outdated
| log.Warn("failed to decode snapshot generator", "err", err) | ||
| return "" | ||
| } | ||
| return fmt.Sprintf(`Wiping: %v, Done: %v, Accounts: %d, Slots: %d, Storage: %d, Marker: %x`, |
There was a problem hiding this comment.
Nitpick:
- we don't have the wiping notion anymore. Wiping will never happen again. I would prefer to not show this info.
- generation marker can indicate to a storage position, which is 2 * 32 bytes length. I would prefer to interpret it a bit further, e.g.
// Figure out whether we're after or within an account
switch len(marker) {
case common.HashLength:
ctx = append(ctx, []interface{}{"at", common.BytesToHash(marker)}...)
case 2 * common.HashLength:
ctx = append(ctx, []interface{}{
"in", common.BytesToHash(marker[:common.HashLength]),
"at", common.BytesToHash(marker[common.HashLength:]),
}...)
}
s1na
reviewed
Nov 19, 2021
s1na
reviewed
Nov 19, 2021
s1na
reviewed
Nov 19, 2021
Co-authored-by: Sina Mahmoodi <[email protected]>
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 18, 2022
* cmd/geth: add db cmd to show metadata * cmd/geth: better output generator status Co-authored-by: Sina Mahmoodi <[email protected]> * cmd: minor Co-authored-by: Sina Mahmoodi <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* cmd/geth: add db cmd to show metadata * cmd/geth: better output generator status Co-authored-by: Sina Mahmoodi <[email protected]> * cmd: minor Co-authored-by: Sina Mahmoodi <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example with a quirky (broken) datadir, where some things don't match up -- both header hashes/number as well as the frozen-count, which is off.