internal/ethapi: use correct signer when serving old blocks #23683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Oct 5, 2021
internal/ethapi/api.go
Outdated
Comment on lines
1297
to
1303
| // First reply protection (EIP155) was a part of Spurious Dragon. | ||
| // Need to distinguish the two HFs because Homestead rejects a subset of S values. | ||
| if config.IsHomestead(big.NewInt(0).SetUint64(blockNumber)) { | ||
| signer = types.HomesteadSigner{} | ||
| } else { | ||
| signer = types.FrontierSigner{} | ||
| } |
There was a problem hiding this comment.
Shouldn't we replace this entire thing (including the clause above) with
signer = types.MakeSigner(config, blockNumber)
fjl
approved these changes
Oct 5, 2021
holiman
approved these changes
Oct 7, 2021
fjl
changed the title
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Oct 7, 2021
…#23683) Fixes ethereum#23681 After the fix I get the address 0x6d6d02e83c4ced98204e20126acf27e9d87b8af2 for the tx mentioned in the ticket, which agrees with etherscan.
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…#23683) Fixes ethereum#23681 After the fix I get the address 0x6d6d02e83c4ced98204e20126acf27e9d87b8af2 for the tx mentioned in the ticket, which agrees with etherscan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23681
After the fix I get the address
0x6d6d02e83c4ced98204e20126acf27e9d87b8af2for the tx mentioned in the ticket which agrees with etherscan