core/vm/instructions.go,interpreter.go | potential issue fix #23535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucwong
requested review from
holiman,
karalabe and
rjl493456442
as code owners
|
The change your proposing actually reverts a fix to a consensus issue. The issue was that returndata was modified during the memory copy, in certain conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some consensus issue occurred after merge this pr in my repo
#23381
but I am not sure it will occur in go-ethereum
It is fixed by this CortexFoundation/CortexTheseus@cb78eb6
I hope it will do some help