cmd/devp2p: fixes for eth and discv4 tests #23155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/devp2p/internal: fix test false positive p2p/discover/v4wire: add besu example
fjl
reviewed
Jul 3, 2021
p2p/discover/v4wire/packet_test.go
Outdated
| "github.com/ethereum/go-ethereum/rlp" | ||
| ) | ||
|
|
||
| func TestDecode(t *testing.T) { |
There was a problem hiding this comment.
I'm not sure we should keep this test. The test basically checks that RLP decoding works, but there are enough tests in package rlp to cover this, I think.
fjl
changed the title
|
@holiman internal tests are failing now, so we can't merge it yet. |
|
Failures fixed now, ptal @fjl |
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Jul 10, 2021
This PR fixes a false positive PONG 'to' endpoint mismatch seen in hive tests:
got {IP:172.17.0.7 UDP:44025 TCP:44025}, want {IP:172.17.0.7 UDP:44025 TCP:0}
Co-authored-by: Felix Lange <[email protected]>
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
This PR fixes a false positive PONG 'to' endpoint mismatch seen in hive tests:
got {IP:172.17.0.7 UDP:44025 TCP:44025}, want {IP:172.17.0.7 UDP:44025 TCP:0}
Co-authored-by: Felix Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive
PONG 'to' endpoint mismatch: got {IP:172.17.0.7 UDP:44025 TCP:44025}, want {IP:172.17.0.7 UDP:44025 TCP:0}in the hive tests, and adds some packet decoding tests.