Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: make genesis parse baseFee correctly #23013

Merged
merged 1 commit into from
Jun 14, 2021
Merged

core: make genesis parse baseFee correctly #23013

merged 1 commit into from
Jun 14, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jun 8, 2021

This is needed to parse genesis basefee with hex encoding which is used for consensus-tests in hive

MariusVanDerWijden
MariusVanDerWijden approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.4 milestone Jun 8, 2021
@karalabe karalabe merged commit ccf53da into ethereum:master Jun 14, 2021
@holiman
Copy link
Contributor Author

holiman commented Jun 14, 2021 •
edited
Loading

Thanks for the merge! It just stopped working, though, because test tests were updated to call the field "baseFeePerGas", for some reason. ethereum/tests#881

@holiman
Copy link
Contributor Author

holiman commented Jun 14, 2021

We need to change this again, to read baseFeePerGas instead of baseFee. It's actually the original term from the the EIP (https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md)

@holiman holiman mentioned this pull request Jun 14, 2021
Merged
@gzliudan gzliudan mentioned this pull request May 24, 2024
Open
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 21, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
b32505c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
508a25e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
8dcfd67
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
a019640
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
37897e1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
4ffe8a4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
01e441b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
a714075
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
2891860
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
d758d84
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
fe7ed24
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
8ed2992
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
2f34b4f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
bd42546
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
815a1bf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
9af0432
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
f0e6ad0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
3c05642
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
901d864
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
79dfa3b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
0c5c869
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
fa4da72
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
17eb546
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
0313d91
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
1891107
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
fd2cf85
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
d23f17e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
0ace21c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
d787caf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
core: make genesis parse baseFee correctly (ethereum#23013)
869c66a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@mumi mumi mumi approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@holiman @MariusVanDerWijden @mumi @karalabe