Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/fetcher: avoid spurious timer events at startup #22652

Merged
merged 4 commits into from
Apr 14, 2021
Merged

eth/fetcher: avoid spurious timer events at startup #22652

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
889e0bf
clear out the channel
r1cs Apr 12, 2021
ccbbf09
Update block_fetcher.go
fjl Apr 13, 2021
90a3399
Update block_fetcher.go
fjl Apr 13, 2021
d056e84
eth/fetcher: fix it
fjl Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eth/fetcher/block_fetcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,10 @@ func (f *BlockFetcher) FilterBodies(peer string, transactions [][]*types.Transac
func (f *BlockFetcher) loop() {
// Iterate the block fetching until a quit is requested
fetchTimer := time.NewTimer(0)
<-fetchTimer.C //clear out the channel

completeTimer := time.NewTimer(0)
<-completeTimer.C
defer fetchTimer.Stop()
defer completeTimer.Stop()

Expand Down