eth: fix tracing state retrieval if requesting the non-dirty genesis #22629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
fix-chain-tracing-from-0
branch
from
c98f8c8
to
2a7c4b6
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tracing based on a clean database (chain tracing), we removed the short-circuit that created a statedb on top of the starting block. That fix was needed to not process blocks on top of the live pruner.
However, we still do need to check if we can make a statedb on top of the starting block using only the disk database. Otherwise a chain tracer starting from the genesis would fail as it would try to reconstruct the genesis state from it's "parent" from the get to.